Exact procedure for committing changes to the OSDK on SVN.
Posted: Sun Apr 14, 2019 4:01 am
Hello kitties,
I will (very) soon (like, this Sunday ) have a few (very) small changes to the OSDK that I want to share with the community so before I do that I would like to be certain of the contribution procedure.
(Note: my goal is not to change that procedure, let us not discuss that, I just want to understand it.)
We discussed this topic in a previous OSDK thread and DBug precised his priorities on this post:
post: viewtopic.php?f=3&t=1805&p=17444#p17424.
If I understand these rules correctly it would seem to me that the context and procedure intended by Dbug are the following:
First of all, no branches are used. Everyone contributes to the same trunk at the same time.
Then, when kitten X wants to contribute his changes to the OSDK back to SVN,
Thanks in advance!
I will (very) soon (like, this Sunday ) have a few (very) small changes to the OSDK that I want to share with the community so before I do that I would like to be certain of the contribution procedure.
(Note: my goal is not to change that procedure, let us not discuss that, I just want to understand it.)
We discussed this topic in a previous OSDK thread and DBug precised his priorities on this post:
post: viewtopic.php?f=3&t=1805&p=17444#p17424.
If I understand these rules correctly it would seem to me that the context and procedure intended by Dbug are the following:
First of all, no branches are used. Everyone contributes to the same trunk at the same time.
Then, when kitten X wants to contribute his changes to the OSDK back to SVN,
- X fetches the latest SVN version locally
- X merges his changes into this latest version (locally, on X's machine),
- X verifies, locally, that the changes still work
- X modifies his changes so that can be enabled/disabled via #define/#ifdef (if appropriate)
- X informs the community officially that there are some changes to be committed
- DBug decides whether he wants the changes or not
- X pushes their changes to the SVN repository (directly on trunk)
- DBug verifies the changes by examining the code and indicates if he wants them or not
- people get the latest SVN and enable the changes on a voluntary basis via #define/#ifdef
- when the changes eventually get validated by the community, someone (X or DBug?) removes the #define/#ifdef in the code and commits to SVN
- a new version of the OSDK is published by DBug
Thanks in advance!